Merged
Conversation
sanmai
commented
Dec 19, 2024
| matrix: | ||
| php-version: | ||
| - "7.4" | ||
| - "8.1" |
Contributor
Author
There was a problem hiding this comment.
We would want to switch to PHP 8.1 for static analysis and other common stages, but there are branch protection rules that demand PHP 7.4. So let's add 8.1 first and tweak the protections later.
lucila
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why? 🤔
Let's start testing the library on PHP 8.4 and fix issues. Specifically, implicit nullable are now deprecated as of PHP 8.4:
Unless we make the change above, we'll see:
This is a non-breaking change, as you can see from the lack of LSP errors: https://3v4l.org/VmME0
Testing Steps ✍️
CI should pass, review the changes.
You're it! 👑
Tag a random reviewer by adding
@Automattic/stream-buildersto the reviewers section, but mention them here for visibility as well.